d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly cleanup driver during remove_one() in mlx5core.

Browse Source 
Cleanup all host resources, SYSCTLs, MSIX vectors and memory used
by the host and only leave the device allocated memory behind, if any,
because it may still be in use, when the PCI remove function is called.
Else future probe calls may fail due to SYSCTLs already existing.

MFC after:		1 week
Sponsored by:		Mellanox Technologies // NVIDIA Networking
This commit is contained in:
Hans Petter Selasky 2020-10-07 17:46:49 +00:00
parent e7a39b856a
commit 194ddc011a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/dev/mlx5/mlx5_core/mlx5_main.c
View File

@ -1665,9 +1665,8 @@ static void remove_one(struct pci_dev *pdev)
struct mlx5_priv *priv = &dev->priv;
if (mlx5_unload_one(dev, priv, true)) {
mlx5_core_err(dev, "mlx5_unload_one failed\n");
mlx5_health_cleanup(dev);
return;
mlx5_core_err(dev, "mlx5_unload_one() failed, leaked %lld bytes\n",
(long long)(dev->priv.fw_pages * MLX5_ADAPTER_PAGE_SIZE));
}
mlx5_pagealloc_cleanup(dev);