d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't forget to free a string allocated by strdup where necessary.

Browse Source 
Found by:	Coverity Prevent
Coverity ID:	CID 3132
This commit is contained in:
cperciva 2007-05-19 05:09:09 +00:00
parent 15bdc412d8
commit 1a5e79cbeb
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/libarchive/archive_write_set_format_shar.c
View File

@ -213,11 +213,14 @@ archive_write_shar_header(struct archive_write *a, struct archive_entry *entry)
/* Try to avoid a lot of redundant mkdir commands. */
if (strcmp(p, ".") == 0) {
/* Don't try to "mkdir ." */
free(p);
} else if (shar->last_dir == NULL) {
ret = shar_printf(a,
"mkdir -p %s > /dev/null 2>&1\n", p);
if (ret != ARCHIVE_OK)
if (ret != ARCHIVE_OK) {
free(p);
return (ret);
}
shar->last_dir = p;
} else if (strcmp(p, shar->last_dir) == 0) {
/* We've already created this exact dir. */
@ -229,11 +232,15 @@ archive_write_shar_header(struct archive_write *a, struct archive_entry *entry)
} else {
ret = shar_printf(a,
"mkdir -p %s > /dev/null 2>&1\n", p);
if (ret != ARCHIVE_OK)
if (ret != ARCHIVE_OK) {
free(p);
return (ret);
}
free(shar->last_dir);
shar->last_dir = p;
}
} else {
free(p);
}
}