d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Similar to r311750, check for the result from smiGetModule to avoid a segfault

Browse Source 
when dereferencing a NULL pointer later on.

Choose to just check for the NULL pointer in the next for-loop for now to fix
the issue with a minimal amount of code churn

sys/queue.h use here would make more sense than using a static table

MFC after:	5 days
This commit is contained in:
ngie 2017-01-09 06:13:27 +00:00
parent 2d9c057b51
commit 1cac8b6d8e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/bsnmp/gensnmpdef/gensnmpdef.c
View File

@ -560,6 +560,8 @@ main(int argc, char *argv[])
level = 0; level = 0;
last = NULL; last = NULL;
for (opt = 0; opt < argc; opt++) { for (opt = 0; opt < argc; opt++) {
if (mods[opt] == NULL) /* smiGetModule failed above */
continue;
n = smiGetFirstNode(mods[opt], SMI_NODEKIND_ANY); n = smiGetFirstNode(mods[opt], SMI_NODEKIND_ANY);
if (n == NULL) if (n == NULL)
continue; continue;