d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libifconfig: Set error in ifconfig_get_groups

Browse Source 
This should return -1 with OTHER/ENOMEM set in the handle when malloc
fails, like everywhere else in libifconfig.

Reviewed by:	kp
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D28964
This commit is contained in:
Ryan Moeller 2021-02-27 08:07:21 +00:00
parent 1d8510c1a6
commit 1d9ba697f9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libifconfig/libifconfig.c
View File

@ -511,7 +511,9 @@ ifconfig_get_groups(ifconfig_handle_t *h, const char *name,
len = ifgr->ifgr_len; len = ifgr->ifgr_len;
ifgr->ifgr_groups = (struct ifg_req *)malloc(len); ifgr->ifgr_groups = (struct ifg_req *)malloc(len);
if (ifgr->ifgr_groups == NULL) { if (ifgr->ifgr_groups == NULL) {
return (1); h->error.errtype = OTHER;
h->error.errcode = ENOMEM;
return (-1);
} }
bzero(ifgr->ifgr_groups, len); bzero(ifgr->ifgr_groups, len);
if (ifconfig_ioctlwrap(h, AF_LOCAL, SIOCGIFGROUP, ifgr) == -1) { if (ifconfig_ioctlwrap(h, AF_LOCAL, SIOCGIFGROUP, ifgr) == -1) {