d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve error handling when I/O split between several BIOs.

Browse Source 
If we get several error codes, handle one with lowest offset.

MFC after:	2 weeks
This commit is contained in:
Alexander Motin 2016-12-19 21:27:18 +00:00
parent c283839dd4
commit 1f0694a680
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/cam/ctl/ctl_backend_block.c
View File

@ -201,7 +201,8 @@ struct ctl_be_block_io {
int num_bios_sent;
int num_bios_done;
int send_complete;
int num_errors;
int first_error;
uint64_t first_error_offset;
struct bintime ds_t0;
devstat_tag_type ds_tag_type;
devstat_trans_flags ds_trans_type;
@ -486,8 +487,12 @@ ctl_be_block_biodone(struct bio *bio)
error = bio->bio_error;
mtx_lock(&be_lun->io_lock);
if (error != 0)
beio->num_errors++;
if (error != 0 &&
(beio->first_error == 0 ||
bio->bio_offset < beio->first_error_offset)) {
beio->first_error = error;
beio->first_error_offset = bio->bio_offset;
}
beio->num_bios_done++;
@ -520,7 +525,8 @@ ctl_be_block_biodone(struct bio *bio)
* If there are any errors from the backing device, we fail the
* entire I/O with a medium error.
*/
if (beio->num_errors > 0) {
error = beio->first_error;
if (error != 0) {
if (error == EOPNOTSUPP) {
ctl_set_invalid_opcode(&io->scsiio);
} else if (error == ENOSPC || error == EDQUOT) {