d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFC: Always explicitly panic in propogate_priority() if we try to propogate

Browse Source 
a lock's priority to a sleeping thread.

Approved by:	re (scottl)
This commit is contained in:
jhb 2006-04-05 21:15:19 +00:00
parent 3a1853983d
commit 1fb84f1627
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
sys/kern/subr_turnstile.c
View File

@ -180,15 +180,21 @@ propagate_priority(struct thread *td)
MPASS(td->td_proc->p_magic == P_MAGIC);
/*
* XXX: The owner of a turnstile can be stale if it is the
* first thread to grab a slock of a sx lock. In that case
* it is possible for us to be at SSLEEP or some other
* weird state. We should probably just return if the state
* isn't SRUN or SLOCK.
* If the thread is asleep, then we are probably about
* to deadlock. To make debugging this easier, just
* panic and tell the user which thread misbehaved so
* they can hopefully get a stack trace from the truly
* misbehaving thread.
*/
KASSERT(!TD_IS_SLEEPING(td),
("sleeping thread (tid %d) owns a non-sleepable lock",
td->td_tid));
if (TD_IS_SLEEPING(td)) {
printf(
"Sleeping thread (tid %d, pid %d) owns a non-sleepable lock\n",
td->td_tid, td->td_proc->p_pid);
#ifdef DDB
db_trace_thread(td, -1);
#endif
panic("sleeping thread");
}
/*
* If this thread already has higher priority than the