d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make_dev(9) can be (and is) called without Giant, so there is no need to

Browse Source 
drop the topology lock and acquire Giant around this call.

Reviewed by:	phk
This commit is contained in:
kris 2007-03-26 21:47:03 +00:00
parent 0e5e1ddffd
commit 21b5ddcd2e
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/geom/geom_dev.c
View File

@ -138,19 +138,11 @@ g_dev_taste(struct g_class *mp, struct g_provider *pp, int insist __unused)
error = g_attach(cp, pp);
KASSERT(error == 0,
("g_dev_taste(%s) failed to g_attach, err=%d", pp->name, error));
/*
* XXX: I'm not 100% sure we can call make_dev(9) without Giant
* yet. Once we can, we don't need to drop topology here either.
*/
unit = alloc_unr(unithdr);
g_topology_unlock();
mtx_lock(&Giant);
dev = make_dev(&g_dev_cdevsw, unit2minor(unit),
UID_ROOT, GID_OPERATOR, 0640, gp->name);
if (pp->flags & G_PF_CANDELETE)
dev->si_flags |= SI_CANDELETE;
mtx_unlock(&Giant);
g_topology_lock();
dev->si_iosize_max = MAXPHYS;
gp->softc = dev;
dev->si_drv1 = gp;