d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't enable interrupts in init_secondary().

Browse Source 
The MI kernel assumes that interrupts will not be enabled on APs until
after the first context switch.  In particular, the problem was causing
occasional deadlocks during boot.

Remove an unneeded intr_disable() added in r335005.

Reviewed by:	jhb (previous version)
MFC after:	1 week
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D18738
This commit is contained in:
Mark Johnston 2019-01-04 17:14:50 +00:00
parent c1959ba49b
commit 23732c0fe3
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/riscv/riscv/mp_machdep.c
View File

@ -227,7 +227,6 @@ init_secondary(uint64_t cpu)
__asm __volatile("mv gp, %0" :: "r"(pcpup));
/* Workaround: make sure wfi doesn't halt the hart */
intr_disable();
csr_set(sie, SIE_SSIE);
csr_set(sip, SIE_SSIE);
@ -253,9 +252,6 @@ init_secondary(uint64_t cpu)
/* Start per-CPU event timers. */
cpu_initclocks_ap();
/* Enable interrupts */
intr_enable();
/* Enable external (PLIC) interrupts */
csr_set(sie, SIE_SEIE);