From 27ed53c3117c6d937c9f55e94a2354345a42a604 Mon Sep 17 00:00:00 2001 From: Mark Johnston Date: Wed, 23 Jan 2019 20:02:17 +0000 Subject: [PATCH] Remove extraneous setutxent() calls in write(1). We already call setutxent() once during initialization. Furthermore, the subsequent calls occur after the process has entered capability mode, so they fail, and attempts to fetch database entries fail as a result. PR: 235096 Submitted by: fullermd@over-yonder.net MFC after: 3 days --- usr.bin/write/write.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.bin/write/write.c b/usr.bin/write/write.c index 2febe3b42302..06cae97d9fc9 100644 --- a/usr.bin/write/write.c +++ b/usr.bin/write/write.c @@ -204,7 +204,6 @@ utmp_chk(char *user, char *tty) struct utmpx lu, *u; strncpy(lu.ut_line, tty, sizeof lu.ut_line); - setutxent(); while ((u = getutxline(&lu)) != NULL) if (u->ut_type == USER_PROCESS && strcmp(user, u->ut_user) == 0) { @@ -237,7 +236,6 @@ search_utmp(int devfd, char *user, char *tty, char *mytty, uid_t myuid) bestatime = 0; user_is_me = 0; - setutxent(); while ((u = getutxent()) != NULL) if (u->ut_type == USER_PROCESS && strcmp(user, u->ut_user) == 0) {