d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make even more copies of hostnames obtained by inet_ntoa(). iruserok()

Browse Source 
could still clobber the static storage, yielding an error message with
a wrong hostname.
This commit is contained in:
Joerg Wunsch 1997-01-27 15:38:46 +00:00
parent 30c8c5e8fa
commit 28f9fdc1ae
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
libexec/rshd/rshd.c
View File

@ -202,6 +202,7 @@ doit(fromp)
char *cp, sig, buf[BUFSIZ];
char cmdbuf[NCARGS+1], locuser[16], remuser[16];
char remotehost[2 * MAXHOSTNAMELEN + 1];
char fromhost[2 * MAXHOSTNAMELEN + 1];
#ifdef KERBEROS
AUTH_DAT *kdata = (AUTH_DAT *) NULL;
@ -333,7 +334,9 @@ doit(fromp)
* in a remote net; look up the name and check that this
* address corresponds to the name.
*/
hostname = hp->h_name;
strncpy(fromhost, hp->h_name, sizeof(fromhost) - 1);
fromhost[sizeof(fromhost) - 1] = 0;
hostname = fromhost;
#ifdef KERBEROS
if (!use_kerberos)
#endif
@ -348,7 +351,10 @@ doit(fromp)
remotehost);
errorstr =
"Couldn't look up address for your host (%s)\n";
hostname = inet_ntoa(fromp->sin_addr);
strncpy(fromhost, inet_ntoa(fromp->sin_addr),
sizeof(fromhost) - 1);
fromhost[sizeof(fromhost) - 1] = 0;
hostname = fromhost;
} else for (; ; hp->h_addr_list++) {
if (hp->h_addr_list[0] == NULL) {
syslog(LOG_NOTICE,
@ -357,7 +363,10 @@ doit(fromp)
hp->h_name);
errorstr =
"Host address mismatch for %s\n";
hostname = inet_ntoa(fromp->sin_addr);
strncpy(fromhost, inet_ntoa(fromp->sin_addr),
sizeof(fromhost) - 1);
fromhost[sizeof(fromhost) - 1] = 0;
hostname = fromhost;
break;
}
if (!bcmp(hp->h_addr_list[0],
@ -368,8 +377,12 @@ doit(fromp)
}
}
}
} else
errorhost = hostname = inet_ntoa(fromp->sin_addr);
} else {
strncpy(fromhost, inet_ntoa(fromp->sin_addr),
sizeof(fromhost) - 1);
fromhost[sizeof(fromhost) - 1] = 0;
errorhost = hostname = fromhost;
}
#ifdef KERBEROS
if (use_kerberos) {