d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a somewhat redundant check on the len arguement to getsockaddr() to

Browse Source 
avoid relying on the minimum memory allocation size to avoid problems.
The check is somewhat redundant because the consumers of the returned
structure will check that sa_len is a protocol-specific larger size.

Submitted by:	Matthew Dillon <dillon@apollo.backplane.com>
Reviewed by:	nectar
MFC after:	30 days
This commit is contained in:
Don Lewis 2004-01-10 08:28:54 +00:00
parent 3f02eaf396
commit 2b77864f1e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/kern/uipc_syscalls.c
View File

@ -1607,6 +1607,8 @@ getsockaddr(namp, uaddr, len)
if (len > SOCK_MAXADDRLEN) if (len > SOCK_MAXADDRLEN)
return ENAMETOOLONG; return ENAMETOOLONG;
if (len < offsetof(struct sockaddr, sa_data[0]))
return EINVAL;
MALLOC(sa, struct sockaddr *, len, M_SONAME, M_WAITOK); MALLOC(sa, struct sockaddr *, len, M_SONAME, M_WAITOK);
error = copyin(uaddr, sa, len); error = copyin(uaddr, sa, len);
if (error) { if (error) {