d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped

Browse Source 
Some CPUs (e.g. AArch64 QEMU) cannot trap on floating point exceptions and
therefore ignore the writes to the floating point control register inside
feenableexcept(). If no exceptions are enabled after
feenableexcept(FE_ALL_EXCEPT), we can assume that the CPU does not
support exceptions and we can then skip the test.

Reviewed By:	dim
Differential Revision: https://reviews.freebsd.org/D29095
This commit is contained in:
Alex Richardson 2021-03-22 11:53:40 +00:00
parent 87d65c747a
commit 2b9dbcd390
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/msun/tests/fenv_test.c
View File

@ -392,7 +392,27 @@ ATF_TC_BODY(masking, tc)
int except, pass, raise, status;
unsigned i;
ATF_CHECK_EQ(0, (fegetexcept() & ALL_STD_EXCEPT));
ATF_REQUIRE_EQ(0, (fegetexcept() & ALL_STD_EXCEPT));
/*
* Some CPUs, e.g. AArch64 QEMU does not support trapping on FP
* exceptions. In that case the trap enable bits are all RAZ/WI, so
* writing to those bits will be ignored and the the next read will
* return all zeroes for those bits. Skip the test if no floating
* point exceptions are supported and mark it XFAIL if some are missing.
*/
ATF_REQUIRE_EQ(0, (feenableexcept(FE_ALL_EXCEPT)));
except = fegetexcept();
if (except == 0) {
atf_tc_skip("CPU does not support trapping on floating point "
"exceptions.");
} else if ((except & ALL_STD_EXCEPT) != ALL_STD_EXCEPT) {
atf_tc_expect_fail("Not all floating point exceptions can be "
"set to trap: %#x vs %#x", except, ALL_STD_EXCEPT);
}
fedisableexcept(FE_ALL_EXCEPT);
ATF_CHECK_EQ(0, (feenableexcept(FE_INVALID|FE_OVERFLOW) & ALL_STD_EXCEPT));
ATF_CHECK_EQ((FE_INVALID | FE_OVERFLOW), (feenableexcept(FE_UNDERFLOW) & ALL_STD_EXCEPT));
ATF_CHECK_EQ((FE_INVALID | FE_OVERFLOW | FE_UNDERFLOW), (fedisableexcept(FE_OVERFLOW) & ALL_STD_EXCEPT));