From 2c7d9bf22fc91cf3cf6625be76de7d22ba731278 Mon Sep 17 00:00:00 2001 From: rpokala Date: Wed, 13 Nov 2019 03:56:51 +0000 Subject: [PATCH] Logging improvements to loader::nfs Include the server IP address when logging nfs_open(), add a few missing "\n"s, and correct a typo. Reviewed by: kevans MFC after: 2 weeks Sponsored by: Panasas Differential Revision: https://reviews.freebsd.org/D22346 --- stand/libsa/nfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/stand/libsa/nfs.c b/stand/libsa/nfs.c index 31a19c0597e5..084c7261f054 100644 --- a/stand/libsa/nfs.c +++ b/stand/libsa/nfs.c @@ -486,7 +486,8 @@ nfs_open(const char *upath, struct open_file *f) #ifdef NFS_DEBUG if (debug) - printf("nfs_open: %s (rootpath=%s)\n", upath, rootpath); + printf("nfs_open: %s (rootip=%s rootpath=%s)\n", upath, + inet_ntoa(rootip), rootpath); #endif if (!rootpath[0]) { printf("no rootpath, no nfs\n"); @@ -691,14 +692,14 @@ nfs_read(struct open_file *f, void *buf, size_t size, size_t *resid) if (cc == -1) { #ifdef NFS_DEBUG if (debug) - printf("nfs_read: read: %s", strerror(errno)); + printf("nfs_read: read: %s\n", strerror(errno)); #endif return (errno); /* XXX - from nfs_readdata */ } if (cc == 0) { #ifdef NFS_DEBUG if (debug) - printf("nfs_read: hit EOF unexpectantly"); + printf("nfs_read: hit EOF unexpectedly\n"); #endif goto ret; }