d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In UDPv6, reduce scope of global udbinfo lock during append to last

Browse Source 
matching socket by dropping it before udp6_append(), and remove
duplicate unlocks of udbinfo and inpcb in sysctl return path.

MFC after:	3 days
This commit is contained in:
rwatson 2008-08-31 13:16:45 +00:00
parent 59f71b4d71
commit 2d23f13f7f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netinet6/udp6_usrreq.c
View File

@ -308,9 +308,9 @@ udp6_input(struct mbuf **mp, int *offp, int proto)
goto badheadlocked;
}
INP_RLOCK(last);
INP_INFO_RUNLOCK(&V_udbinfo);
udp6_append(last, m, off, &fromsa);
INP_RUNLOCK(last);
INP_INFO_RUNLOCK(&V_udbinfo);
return (IPPROTO_DONE);
}
/*
@ -465,8 +465,6 @@ udp6_getcred(SYSCTL_HANDLER_ARGS)
INP_INFO_RUNLOCK(&V_udbinfo);
error = ENOENT;
}
INP_RUNLOCK(inp);
INP_INFO_RUNLOCK(&V_udbinfo);
if (error == 0)
error = SYSCTL_OUT(req, &xuc, sizeof(struct xucred));
return (error);