d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't share sig handlers after an exec

Browse Source 
Reviewed by:	Alfred Perlstein
This commit is contained in:
Guido van Rooij 2001-07-09 19:01:42 +00:00
parent 9b956e9897
commit 333ea48563
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
sys/kern/kern_exec.c
View File

@ -41,13 +41,14 @@
#include <sys/imgact.h>
#include <sys/imgact_elf.h>
#include <sys/wait.h>
#include <sys/malloc.h>
#include <sys/proc.h>
#include <sys/pioctl.h>
#include <sys/malloc.h>
#include <sys/namei.h>
#include <sys/sysent.h>
#include <sys/shm.h>
#include <sys/sysctl.h>
#include <sys/user.h>
#include <sys/vnode.h>
#include <vm/vm.h>
@ -250,6 +251,27 @@ execve(p, uap)
p->p_fd = tmp;
}
/*
* For security and other reasons, signal handlers cannot
* be shared after an exec. The new proces gets a copy of the old
* handlers. In execsigs(), the new process wll have its signals
* reset.
*/
if (p->p_procsig->ps_refcnt > 1) {
struct procsig *newprocsig;
MALLOC(newprocsig, struct procsig *, sizeof(struct procsig),
M_SUBPROC, M_WAITOK);
bcopy(p->p_procsig, newprocsig, sizeof(*newprocsig));
p->p_procsig->ps_refcnt--;
p->p_procsig = newprocsig;
p->p_procsig->ps_refcnt = 1;
if (p->p_sigacts == &p->p_addr->u_sigacts)
panic("shared procsig but private sigacts?\n");
p->p_addr->u_sigacts = *p->p_sigacts;
p->p_sigacts = &p->p_addr->u_sigacts;
}
/* Stop profiling */
stopprofclock(p);