d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove a death threat from the FreeBSD sources

Browse Source 
Reported by:	koobs@, araujo@, linimon@, bjk@, emaste@, jhb@, ngie@, cem@
Maintainer timeout:	des@
This commit is contained in:
Conrad Meyer 2016-12-01 02:21:36 +00:00
parent 909f007fb8
commit 33d19692e8
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/libutil/flopen.c
View File

@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$");
/* /*
* Reliably open and lock a file. * Reliably open and lock a file.
* *
* DO NOT, UNDER PAIN OF DEATH, modify this code without first reading the * Please do not modify this code without first reading the revision history
* revision history and discussing your changes with <des@freebsd.org>. * and discussing your changes with <des@freebsd.org>. Don't be fooled by the
* Don't be fooled by the code's apparent simplicity; there would be no * code's apparent simplicity; there would be no need for this function if it
* need for this function if it was as easy to get right as you think. * was easy to get right.
*/ */
int int
flopen(const char *path, int flags, ...) flopen(const char *path, int flags, ...)
@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...)
errno = serrno; errno = serrno;
return (-1); return (-1);
} }
#ifdef DONT_EVEN_THINK_ABOUT_IT /*
* The following change is provided as a specific example to
* avoid.
*/
#if 0
if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) { if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) {
serrno = errno; serrno = errno;
(void)close(fd); (void)close(fd);