d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bootpd: avoid the same error indication for different issues

Browse Source 
There were several (apparently) copy-pasted NEED validation macros,
leading to the same error string for different issues.  Change the
YP and NTP tags so they are distinct.

PR:		30863
Submitted by:	Dan Lukes <dan@obluda.cz>
Reviewed by:	markj
MFC after:	1 week
Event:		Waterloo Hackathon 2019
This commit is contained in:
Ed Maste 2019-05-21 21:27:14 +00:00
parent 4e7d8292ec
commit 34366bc932
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libexec/bootpd/dovend.c
View File

@ -147,7 +147,7 @@ dovend_rfc1497(hp, buf, len)
if (insert_ip(TAG_NIS_SERVER,
hp->nis_server,
&vp, &bytesleft))
NEED(8, "ds");
NEED(8, "ys");
}
if (hp->flags.nis_domain) {
/*
@ -155,7 +155,7 @@ dovend_rfc1497(hp, buf, len)
* TAG_NIS_DOMAIN and length.
*/
len = strlen(hp->nis_domain->string);
NEED((len + 2), "dn");
NEED((len + 2), "yn");
*vp++ = TAG_NIS_DOMAIN;
*vp++ = (byte) (len & 0xFF);
bcopy(hp->nis_domain->string, vp, len);
@ -187,7 +187,7 @@ dovend_rfc1497(hp, buf, len)
if (insert_ip(TAG_NTP_SERVER,
hp->ntp_server,
&vp, &bytesleft))
NEED(8, "ts");
NEED(8, "nt");
}
/*
* I wonder: If the hostname were "promoted" into the BOOTP