From 3764d53f49154237f2a09088144599fe67910c30 Mon Sep 17 00:00:00 2001 From: ngie Date: Sat, 23 Apr 2016 08:10:04 +0000 Subject: [PATCH] Fix looking for "UTC" at start of ptr by using strnmp instead of improperly unrolled equivalent CID: 1347118 MFC after: 1 week Reported by: Coverity Sponsored by: EMC / Isilon Storage Division --- usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c index dc22c697e104..43dd9a47d524 100644 --- a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c +++ b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c @@ -440,8 +440,8 @@ snmp_date2asn_oid(char *str, struct asn_oid *oid) /* 'UTC' - optional */ ptr = endptr + 1; - if (*ptr == 'U' && *(ptr + 1) == 'T' && *(ptr + 1) == 'C') - ptr += 3; + if (strncmp(ptr, "UTC", strlen("UTC")) == 0) + ptr += strlen("UTC"); /* '+/-' */ if (*ptr == '-' || *ptr == '+') {