d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't release the cfiscsi session refcount too early. It wasn't

Browse Source 
observed to fix any actual error, but it's the right thing to do
from the correctness point of view.

Tested by:	Eugene M. Zheganin <emz at norma.perm.ru>
MFC after:	1 month
This commit is contained in:
Edward Tomasz Napierala 2017-01-04 12:50:44 +00:00
parent ccd0cf8ffa
commit 3a408ce90d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/cam/ctl/ctl_frontend_iscsi.c
View File

@ -2963,7 +2963,6 @@ cfiscsi_done(union ctl_io *io)
request = io->io_hdr.ctl_private[CTL_PRIV_FRONTEND].ptr;
cs = PDU_SESSION(request);
refcount_release(&cs->cs_outstanding_ctl_pdus);
switch (request->ip_bhs->bhs_opcode & ~ISCSI_BHS_OPCODE_IMMEDIATE) {
case ISCSI_BHS_OPCODE_SCSI_COMMAND:
@ -2976,4 +2975,6 @@ cfiscsi_done(union ctl_io *io)
panic("cfiscsi_done called with wrong opcode 0x%x",
request->ip_bhs->bhs_opcode);
}
refcount_release(&cs->cs_outstanding_ctl_pdus);
}