d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Initialize a stack variable in mprsas_get_sas_address_for_sata_disk

Browse Source 
Thought it's difficult to reproduce, I think this variable was responsible
for a use-after-free panic when a SATA disk timed out responding to a SATA
identify command during boot.

Submitted by:	slm
Reviewed by:	slm
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D9364
This commit is contained in:
asomers 2017-01-30 19:49:08 +00:00
parent dfb4f0694a
commit 3ceef2b6ba
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sys/dev/mpr/mpr_sas_lsi.c
View File

@ -911,6 +911,7 @@ mprsas_get_sas_address_for_sata_disk(struct mpr_softc *sc,
u8 sas_status;
memset(&ata_identify, 0, sizeof(ata_identify));
memset(&mpi_reply, 0, sizeof(mpi_reply));
try_count = 0;
do {
rc = mprsas_get_sata_identify(sc, handle, &mpi_reply,