Drivers may pass runt packets to filter. This is okay.

Reviewed by: gallatin
2019-09-13 22:36:04 +00:00 · 2019-09-13 22:36:04 +00:00 · 3d08ed450e
commit 3d08ed450e
parent 40f6431286
1 changed files with 4 additions and 1 deletions
--- a/sys/netpfil/ipfw/ip_fw2.c
+++ b/sys/netpfil/ipfw/ip_fw2.c
@ -1448,7 +1448,10 @@ ipfw_chk(struct ip_fw_args *args)
 do {								\
 	int x = (_len) + T + EHLEN;				\
 	if (mem) {						\
-		MPASS(pktlen >= x);				\
+		if (__predict_false(pktlen < x)) {		\
+			unlock;					\
+			goto pullup_failed;			\
+		}						\
 		p = (char *)args->mem + (_len) + EHLEN;		\
 	} else {						\
 		if (__predict_false((m)->m_len < x)) {		\