d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cast arg_max to size_t when comparing it (times 4, plus 1) against SIZE_MAX. I

Browse Source 
was worried about truncation of arg_max by this cast, but if it gets truncated,
we know it'll obviously be greater than SIZE_MAX anyway.

Big pointy hat to:	jmallett
Submitted by:		keramida
This commit is contained in:
Juli Mallett 2002-06-06 20:29:39 +00:00
parent 033340171a
commit 3d0d5dccc1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bin/ps/fmt.c
View File

@ -70,7 +70,8 @@ shquote(char **argv)
if (buf == NULL) {
if ((arg_max = sysconf(_SC_ARG_MAX)) == -1)
errx(1, "sysconf _SC_ARG_MAX failed");
if (arg_max >= LONG_MAX / 4 || 4 * arg_max + 1 > SIZE_MAX)
if (arg_max >= LONG_MAX / 4 ||
4 * (size_t)arg_max + 1 > SIZE_MAX)
errx(1, "sysconf _SC_ARG_MAX preposterously large");
buf_size = 4 * arg_max + 1;
if ((buf = malloc(buf_size)) == NULL)