d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate unnecessary calls to wakeup(); no one sleeps on &aio_freeproc.

Browse Source 
Eliminate an unused flag, AIOP_SCHED; it's cleared but never set.
This commit is contained in:
alc 2005-05-30 18:02:00 +00:00
parent 7f33e6190e
commit 3ecc8d1129
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sys/kern/vfs_aio.c
View File

@ -196,7 +196,6 @@ struct aiocblist {
* AIO process info * AIO process info
*/ */
#define AIOP_FREE 0x1 /* proc on free queue */ #define AIOP_FREE 0x1 /* proc on free queue */
#define AIOP_SCHED 0x2 /* proc explicitly scheduled */
struct aiothreadlist { struct aiothreadlist {
int aiothreadflags; /* AIO proc flags */ int aiothreadflags; /* AIO proc flags */
@ -797,8 +796,6 @@ aio_daemon(void *uproc)
/* /*
* Place thread (lightweight process) onto the AIO free thread list. * Place thread (lightweight process) onto the AIO free thread list.
*/ */
if (TAILQ_EMPTY(&aio_freeproc))
wakeup(&aio_freeproc);
TAILQ_INSERT_HEAD(&aio_freeproc, aiop, list); TAILQ_INSERT_HEAD(&aio_freeproc, aiop, list);
splx(s); splx(s);
@ -843,7 +840,6 @@ aio_daemon(void *uproc)
aiop->aiothreadflags &= ~AIOP_FREE; aiop->aiothreadflags &= ~AIOP_FREE;
splx(s); splx(s);
} }
aiop->aiothreadflags &= ~AIOP_SCHED;
/* /*
* Check for jobs. * Check for jobs.
@ -972,13 +968,7 @@ aio_daemon(void *uproc)
curcp = mycp; curcp = mycp;
} }
/*
* If we are the first to be put onto the free queue, wakeup
* anyone waiting for a daemon.
*/
s = splnet(); s = splnet();
if (TAILQ_EMPTY(&aio_freeproc))
wakeup(&aio_freeproc);
TAILQ_INSERT_HEAD(&aio_freeproc, aiop, list); TAILQ_INSERT_HEAD(&aio_freeproc, aiop, list);
aiop->aiothreadflags |= AIOP_FREE; aiop->aiothreadflags |= AIOP_FREE;
splx(s); splx(s);
@ -987,8 +977,7 @@ aio_daemon(void *uproc)
* If daemon is inactive for a long time, allow it to exit, * If daemon is inactive for a long time, allow it to exit,
* thereby freeing resources. * thereby freeing resources.
*/ */
if ((aiop->aiothreadflags & AIOP_SCHED) == 0 && if (tsleep(aiop->aiothread, PRIBIO, "aiordy", aiod_lifetime)) {
tsleep(aiop->aiothread, PRIBIO, "aiordy", aiod_lifetime)) {
s = splnet(); s = splnet();
if (TAILQ_EMPTY(&aio_jobs)) { if (TAILQ_EMPTY(&aio_jobs)) {
if ((aiop->aiothreadflags & AIOP_FREE) && if ((aiop->aiothreadflags & AIOP_FREE) &&