From 3fa561a45bde5bad3e95691b559dcf2f55e00684 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Tue, 7 Nov 2017 15:01:38 +0000 Subject: [PATCH] Note interactive shell errors for make buildenv and add a warning for people tempted to add back the || true to get rid of them. Sponsored by: Netflix --- Makefile.inc1 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Makefile.inc1 b/Makefile.inc1 index e306f7dd0615..2bf120c5312e 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -988,6 +988,14 @@ buildenvvars: .PHONY .endif .endif BUILDENV_DIR?= ${.CURDIR} +# +# Note: make will report any errors the shell reports. This can +# be odd if the last command in an interactive shell generates an +# error or is terminated by SIGINT. These reported errors look bad, +# but are harmless. Allowing them also allows BUIDLENV_SHELL to +# be a complex command whose status will be returned to the caller. +# Some scripts in tools rely on this behavior to report build errors. +# buildenv: .PHONY @echo Entering world for ${TARGET_ARCH}:${TARGET} .if ${BUILDENV_SHELL:M*zsh*}