From 410604696d3c08a05add9da29d3342c816fddc5b Mon Sep 17 00:00:00 2001 From: Pawel Jakub Dawidek Date: Fri, 14 Dec 2012 15:03:12 +0000 Subject: [PATCH] If we are not going to clear the dump (we are either just checking if the dump exists or we want to keep it), open device read-only. Obtained from: WHEEL Systems --- sbin/savecore/savecore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/savecore/savecore.c b/sbin/savecore/savecore.c index bbde36cbab2b..2b9b6d8671a5 100644 --- a/sbin/savecore/savecore.c +++ b/sbin/savecore/savecore.c @@ -394,7 +394,7 @@ DoFile(const char *savedir, const char *device) if (verbose) printf("checking for kernel dump on device %s\n", device); - fd = open(device, O_RDWR); + fd = open(device, (checkfor || keep) ? O_RDONLY : O_RDWR); if (fd < 0) { syslog(LOG_ERR, "%s: %m", device); return; @@ -612,7 +612,7 @@ DoFile(const char *savedir, const char *device) printf("dump saved\n"); nuke: - if (clear || !keep) { + if (!keep) { if (verbose) printf("clearing dump header\n"); memcpy(kdhl.magic, KERNELDUMPMAGIC_CLEARED, sizeof kdhl.magic);