d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a possible NULL-pointer dereference on the pfsync(4) reconfiguration.

Browse Source 
Reported by:	Eugene M. Zheganin
This commit is contained in:
Andrey V. Elsukov 2013-07-29 13:17:18 +00:00
parent 18f8f46e9f
commit 415077bad9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/netpfil/pf/if_pfsync.c
View File

@ -1324,7 +1324,10 @@ pfsyncioctl(struct ifnet *ifp, u_long cmd, caddr_t data)
else if ((sifp = ifunit_ref(pfsyncr.pfsyncr_syncdev)) == NULL)
return (EINVAL);
if (pfsyncr.pfsyncr_syncpeer.s_addr == 0 && sifp != NULL)
if (sifp != NULL && (
pfsyncr.pfsyncr_syncpeer.s_addr == 0 ||
pfsyncr.pfsyncr_syncpeer.s_addr ==
htonl(INADDR_PFSYNC_GROUP)))
mship = malloc((sizeof(struct in_multi *) *
IP_MIN_MEMBERSHIPS), M_PFSYNC, M_WAITOK | M_ZERO);