d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Oops, when trying the dirhash sequential-access optimisation,

Browse Source 
compare the slot offset against the predicted offset, not a boolean
flag. This typo effectively disabled the sequential optimisation,
but was otherwise harmless.

Not surprisingly, fixing this improves performance in the sequential
access case. I am seeing a 7% speedup on one machine here; using
dirhash when sequentially looking up directory entries is now about
5% faster instead of 2% slower than the non-dirhash case.

Submitted by:	KOIE Hidetaka <koie@suri.co.jp>
MFC after:	1 week
This commit is contained in:
Ian Dowse 2001-11-14 15:08:07 +00:00
parent 6d852b5bdb
commit 4202b366fc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/ufs/ufs/ufs_dirhash.c
View File

@ -378,7 +378,7 @@ ufsdirhash_lookup(struct inode *ip, char *name, int namelen, doff_t *offp,
*/
for (i = slot; (offset = DH_ENTRY(dh, i)) != DIRHASH_EMPTY;
i = WRAPINCR(i, dh->dh_hlen))
if (offset == dh->dh_seqopt)
if (offset == dh->dh_seqoff)
break;
if (offset == dh->dh_seqoff) {
/*