d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Install a SIGCHLD handler so select(2) will be interrupted when a child

Browse Source 
terminates.  Without this patch, 'make -j1 buildworld' takes about 30%
longer than 'make -B buildworld' on my 2.4 GHz P4; the difference is
probably even larger on faster systems.  With this patch, there is no
perceptible difference in wall time between the two.

Submitted by:	bde
MFC after:	3 days
This commit is contained in:
Dag-Erling Smørgrav 2003-12-13 15:26:27 +00:00
parent fc2ada1918
commit 4358431405
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
usr.bin/make/main.c
View File

@ -410,6 +410,10 @@ chdir_verify_path(char *path, char *obpath)
return 0; return 0;
} }
void
catch_child(int sig)
{
}
/*- /*-
* main -- * main --
@ -452,6 +456,22 @@ main(int argc, char **argv)
/* avoid faults on read-only strings */ /* avoid faults on read-only strings */
static char syspath[] = _PATH_DEFSYSPATH; static char syspath[] = _PATH_DEFSYSPATH;
{
/*
* Catch SIGCHLD so that we get kicked out of select() when we
* need to look at a child. This is only known to matter for the
* -j case (perhaps without -P).
*
* XXX this is intentionally misplaced.
*/
struct sigaction sa;
sigemptyset(&sa.sa_mask);
sa.sa_flags = SA_RESTART | SA_NOCLDSTOP;
sa.sa_handler = catch_child;
sigaction(SIGCHLD, &sa, NULL);
}
#ifdef WANT_ENV_MKLVL #ifdef WANT_ENV_MKLVL
if ((iMkLvl = szMkLvl ? atoi(szMkLvl) : 0) < 0) { if ((iMkLvl = szMkLvl ? atoi(szMkLvl) : 0) < 0) {
iMkLvl = 0; iMkLvl = 0;