d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move KTRUSERRET() from userret() to ast(). It's a really long

Browse Source 
detour - it writes ktrace entries to the filesystem - so the overhead
of ast() won't make any difference.

Reviewed by:	kib
Sponsored by:	DARPA
Differential Revision:	https://reviews.freebsd.org/D26404
This commit is contained in:
Edward Tomasz Napierala 2020-10-03 12:03:08 +00:00
parent fedeb08b6a
commit 4658877815
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/kern/kern_ktrace.c
View File

@ -347,6 +347,9 @@ ktr_enqueuerequest(struct thread *td, struct ktr_request *req)
mtx_lock(&ktrace_mtx); mtx_lock(&ktrace_mtx);
STAILQ_INSERT_TAIL(&td->td_proc->p_ktr, req, ktr_list); STAILQ_INSERT_TAIL(&td->td_proc->p_ktr, req, ktr_list);
mtx_unlock(&ktrace_mtx); mtx_unlock(&ktrace_mtx);
thread_lock(td);
td->td_flags |= TDF_ASTPENDING;
thread_unlock(td);
} }
/* /*

7
sys/kern/subr_trap.c
View File

@ -130,9 +130,6 @@ userret(struct thread *td, struct trapframe *frame)
PROC_UNLOCK(p); PROC_UNLOCK(p);
} }
#endif #endif
#ifdef KTRACE
KTRUSERRET(td);
#endif
/* /*
* Charge system time if profiling. * Charge system time if profiling.
@ -341,6 +338,10 @@ ast(struct trapframe *framep)
if (td->td_pflags & TDP_SIGFASTPENDING) if (td->td_pflags & TDP_SIGFASTPENDING)
sigfastblock_setpend(td, false); sigfastblock_setpend(td, false);
#ifdef KTRACE
KTRUSERRET(td);
#endif
/* /*
* We need to check to see if we have to exit or wait due to a * We need to check to see if we have to exit or wait due to a
* single threading requirement or some other STOP condition. * single threading requirement or some other STOP condition.