d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix scope of bridge_header and bridge_pcix_cap in mthca_reset(..)

Browse Source 
They're only used in the __linux__ case

Differential Revision: https://reviews.freebsd.org/D4332
MFC after: 1 week
Reported by: cppcheck
Reviewed by: hselasky
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2015-12-04 09:01:58 +00:00
parent a4889f2dd0
commit 4722f6ef28
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/ofed/drivers/infiniband/hw/mthca/mthca_reset.c
View File

@ -43,9 +43,13 @@ int mthca_reset(struct mthca_dev *mdev)
int i;
int err = 0;
u32 *hca_header = NULL;
#ifdef __linux__
u32 *bridge_header = NULL;
#endif
struct pci_dev *bridge = NULL;
#ifdef __linux__
int bridge_pcix_cap = 0;
#endif
int hca_pcie_cap = 0;
int hca_pcix_cap = 0;
@ -195,6 +199,7 @@ int mthca_reset(struct mthca_dev *mdev)
}
good:
#ifdef __linux__
/* Now restore the PCI headers */
if (bridge) {
if (pci_write_config_dword(bridge, bridge_pcix_cap + 0x8,
@ -235,6 +240,7 @@ int mthca_reset(struct mthca_dev *mdev)
goto out;
}
}
#endif
if (hca_pcix_cap) {
if (pci_write_config_dword(mdev->pdev, hca_pcix_cap,
@ -289,8 +295,8 @@ int mthca_reset(struct mthca_dev *mdev)
#ifdef __linux__
if (bridge)
pci_dev_put(bridge);
#endif
kfree(bridge_header);
#endif
kfree(hca_header);
return err;