d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usr.sbin/bhyveload: don't leak an fd if a device can't be opened

Browse Source 
Coverity CID:	1194167
Approved by:	markj, jhb
Differential Revision:	https://reviews.freebsd.org/D20935
This commit is contained in:
seanc 2019-07-12 18:38:18 +00:00
parent b5a05fcd18
commit 489b0cc9ad
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
usr.sbin/bhyveload/bhyveload.c
View File

@ -664,21 +664,19 @@ altcons_open(char *path)
static int static int
disk_open(char *path) disk_open(char *path)
{ {
int err, fd; int fd;
if (ndisks >= NDISKS) if (ndisks >= NDISKS)
return (ERANGE); return (ERANGE);
err = 0;
fd = open(path, O_RDONLY); fd = open(path, O_RDONLY);
if (fd < 0)
return (errno);
if (fd > 0) { disk_fd[ndisks] = fd;
disk_fd[ndisks] = fd; ndisks++;
ndisks++;
} else
err = errno;
return (err); return (0);
} }
static void static void