d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't treat an error from g_mirror_clear_metadata() as fatal.

Browse Source 
Such errors can occur as the result of a write error or because the disk
backing the mirror element was removed. They result in a generation ID bump
on all active elements of the mirror, so we can safely disconnect the mirror
component rather than destroy it.

MFC after:	2 weeks
Sponsored by:	EMC / Isilon Storage Division
Differential Revision:	https://reviews.freebsd.org/D7750
This commit is contained in:
Mark Johnston 2016-09-06 23:42:59 +00:00
parent 40c5032d32
commit 4bfb585351
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/geom/mirror/g_mirror.c
View File

@ -2678,8 +2678,12 @@ g_mirror_update_disk(struct g_mirror_disk *disk, u_int state)
int error;
error = g_mirror_clear_metadata(disk);
if (error != 0)
return (error);
if (error != 0) {
G_MIRROR_DEBUG(0,
"Device %s: failed to clear metadata on %s: %d.",
sc->sc_name, g_mirror_get_diskname(disk), error);
break;
}
DISK_STATE_CHANGED();
G_MIRROR_DEBUG(0, "Device %s: provider %s destroyed.",
sc->sc_name, g_mirror_get_diskname(disk));