d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fusefs: remove the vfs.fusefs.sync_resize syctl

Browse Source 
This sysctl was added > 6.5 years ago for no clear purpose.  I'm guessing
that it may have had something to do with the incomplete attribute cache.
But the attribute cache works now.  Since there's no clear motivation for
this sysctl, it's best to remove it.

Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Alan Somers 2019-05-13 19:47:31 +00:00
parent bad4c94dc8
commit 4d09e76a73
5 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
UPDATING
View File

@ -37,9 +37,9 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW:
been removed from mount_fusefs(8). You can safely remove them from
your scripts, because they had no effect.
The vfs.fusefs.fix_broken_io sysctl has been removed. If you felt the
need to set it to a non-default value, please tell asomers@FreeBSD.org
why.
The vfs.fusefs.fix_broken_io and vfs.fusefs.sync_resize sysctls have
been removed. If you felt the need to set either to a non-default
value, please tell asomers@FreeBSD.org why.
20190507:
The IPSEC option has been removed from GENERIC. Users requiring

1
share/man/man5/fusefs.5
View File

@ -105,7 +105,6 @@ misbehaving.
.\" vfs.fusefs.iov_credit: I don't understand it well enough
.\" vfs.fusefs.iov_permanent_bufsize: I don't understand it well enough
.\" vfs.fusefs.fix_broken_io: I don't understand it well enough
.\" vfs.fusefs.sync_resize: useless and should be removed
.\" vfs.fusefs.refresh_size: probably useless?
.\" vfs.fusefs.mmap_enable: why is this optional?
.\" vfs.fusefs.data_cache_invalidate: what is this needed for?

2
sys/fs/fuse/fuse_io.c
View File

@ -709,7 +709,7 @@ fuse_write_biobackend(struct vnode *vp, struct uio *uio,
break;
} while (uio->uio_resid > 0 && n > 0);
if (fuse_sync_resize && (fvdat->flag & FN_SIZECHANGE) != 0)
if ((fvdat->flag & FN_SIZECHANGE) != 0)
fuse_vnode_savesize(vp, cred, pid);
return (err);

1
sys/fs/fuse/fuse_ipc.h
View File

@ -231,7 +231,6 @@ enum fuse_data_cache_mode {
extern int fuse_data_cache_mode;
extern int fuse_data_cache_invalidate;
extern int fuse_mmap_enable;
extern int fuse_sync_resize;
static inline struct fuse_data *
fuse_get_mpdata(struct mount *mp)

7
sys/fs/fuse/fuse_node.c
View File

@ -135,13 +135,6 @@ SYSCTL_INT(_vfs_fusefs, OID_AUTO, refresh_size, CTLFLAG_RW,
"If non-zero, and no dirty file extension data is buffered, fetch file "
"size before write operations");
int fuse_sync_resize = 1;
SYSCTL_INT(_vfs_fusefs, OID_AUTO, sync_resize, CTLFLAG_RW,
&fuse_sync_resize, 0,
"If a cached write extended a file, inform FUSE filesystem of the changed"
"size immediately subsequent to the issued writes");
static int
sysctl_fuse_cache_mode(SYSCTL_HANDLER_ARGS)
{