From 4e95375678574798d60ce3e03ebbb163ec35d3a5 Mon Sep 17 00:00:00 2001 From: Robert Watson Date: Tue, 3 Jun 2008 11:06:34 +0000 Subject: [PATCH] Add an XXX comment regarding a bug I introduced when modifying the behavior of audit log vnode rotation: on shutdown, we may not properly drain all pending records, which could lead to lost records during system shutdown. --- sys/security/audit/audit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/security/audit/audit.c b/sys/security/audit/audit.c index 5f345f7b1ffb..ede47c9c619a 100644 --- a/sys/security/audit/audit.c +++ b/sys/security/audit/audit.c @@ -269,6 +269,9 @@ SYSINIT(audit_init, SI_SUB_AUDIT, SI_ORDER_FIRST, audit_init, NULL); * Drain the audit queue and close the log at shutdown. Note that this can * be called both from the system shutdown path and also from audit * configuration syscalls, so 'arg' and 'howto' are ignored. + * + * XXXRW: In FreeBSD 7.x and 8.x, this fails to wait for the record queue to + * drain before returning, which could lead to lost records on shutdown. */ void audit_shutdown(void *arg, int howto)