From 4e9e03d38e852ee3ab1911310614b99fa17cc82f Mon Sep 17 00:00:00 2001 From: truckman Date: Fri, 13 May 2016 00:17:57 +0000 Subject: [PATCH] Use strlcpy() instead of strncpy() to ensure that ret->name is NUL terminated. The source and destination buffers are the same size and the source *should* be NUL terminated, but be paranoid. Reported by: Coverity CID: 1011274 MFC after: 1 week --- usr.sbin/timed/timed/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/timed/timed/master.c b/usr.sbin/timed/timed/master.c index 9a130bfb6993..2bc3f85c5e3a 100644 --- a/usr.sbin/timed/timed/master.c +++ b/usr.sbin/timed/timed/master.c @@ -623,7 +623,7 @@ addmach(char *name, struct sockaddr_in *addr, struct netinfo *ntp) } ret->addr = *addr; ret->ntp = ntp; - (void)strncpy(ret->name, name, sizeof(ret->name)); + (void)strlcpy(ret->name, name, sizeof(ret->name)); ret->good = good_host_name(name); ret->l_fwd = &self; ret->l_bak = self.l_bak;