From 4ee6e70ef3bd0c318ec78f7c38277eed24db46e2 Mon Sep 17 00:00:00 2001 From: Poul-Henning Kamp Date: Tue, 28 Jan 2003 22:44:12 +0000 Subject: [PATCH] Check bounds for index before dereferencing memory past end of array. Found by: FlexeLint --- sys/netinet/ip_divert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/ip_divert.c b/sys/netinet/ip_divert.c index f9bad2ca1fb8..bd8ea4db0e89 100644 --- a/sys/netinet/ip_divert.c +++ b/sys/netinet/ip_divert.c @@ -284,7 +284,7 @@ div_output(struct socket *so, struct mbuf *m, * The name is user supplied data so don't trust its size * or that it is zero terminated. */ - for (i = 0; sin->sin_zero[i] && i < sizeof(sin->sin_zero); i++) + for (i = 0; i < sizeof(sin->sin_zero) && sin->sin_zero[i]; i++) ; if ( i > 0 && i < sizeof(sin->sin_zero)) m->m_pkthdr.rcvif = ifunit(sin->sin_zero);