d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix lock ordering panic by not calling ether_ioctl with port lock held

Browse Source 
Reported by: rrs
This commit is contained in:
Kip Macy 2008-01-16 21:33:34 +00:00
parent 5e2597b9f0
commit 4f6a96ae5b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/cxgb/cxgb_main.c
View File

@ -1772,15 +1772,15 @@ cxgb_ioctl(struct ifnet *ifp, unsigned long command, caddr_t data)
break;
case SIOCSIFADDR:
case SIOCGIFADDR:
PORT_LOCK(p);
if (ifa->ifa_addr->sa_family == AF_INET) {
PORT_LOCK(p);
ifp->if_flags |= IFF_UP;
if (!(ifp->if_drv_flags & IFF_DRV_RUNNING))
cxgb_init_locked(p);
arp_ifinit(ifp, ifa);
PORT_UNLOCK(p);
} else
error = ether_ioctl(ifp, command, data);
PORT_UNLOCK(p);
break;
case SIOCSIFFLAGS:
callout_drain(&p->adapter->cxgb_tick_ch);