d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fusefs: remove the vfs.fusefs.refresh_size sysctl

Browse Source 
This was added > 6.5 years ago with no evident reason why.  It probably had
something to do with the incomplete cached attribute implementation.  But
cache attributes work now.  I see no reason to retain this sysctl.

Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Alan Somers 2019-05-13 20:31:10 +00:00
parent c4fbda2b2c
commit 515183969d
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
UPDATING
View File

@ -37,9 +37,10 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW:
been removed from mount_fusefs(8). You can safely remove them from
your scripts, because they had no effect.
The vfs.fusefs.fix_broken_io and vfs.fusefs.sync_resize sysctls have
been removed. If you felt the need to set either to a non-default
value, please tell asomers@FreeBSD.org why.
The vfs.fusefs.fix_broken_io, vfs.fusefs.sync_resize, and
vfs.fusefs.refresh_size sysctls have been removed. If you felt the
need to set any of them to a non-default value, please tell
asomers@FreeBSD.org why.
20190507:
The IPSEC option has been removed from GENERIC. Users requiring

14
sys/fs/fuse/fuse_node.c
View File

@ -128,13 +128,6 @@ SYSCTL_INT(_vfs_fusefs, OID_AUTO, mmap_enable, CTLFLAG_RW,
"If non-zero, and data_cache_mode is also non-zero, enable mmap(2) of "
"FUSE files");
int fuse_refresh_size = 0;
SYSCTL_INT(_vfs_fusefs, OID_AUTO, refresh_size, CTLFLAG_RW,
&fuse_refresh_size, 0,
"If non-zero, and no dirty file extension data is buffered, fetch file "
"size before write operations");
static int
sysctl_fuse_cache_mode(SYSCTL_HANDLER_ARGS)
{
@ -409,9 +402,14 @@ fuse_vnode_refreshsize(struct vnode *vp, struct ucred *cred)
if ((fvdat->flag & FN_SIZECHANGE) != 0 ||
fuse_data_cache_mode == FUSE_CACHE_UC ||
(fuse_refresh_size == 0 && fvdat->filesize != 0))
fvdat->filesize != 0)
return 0;
/*
* TODO: replace VOP_GETATTR with fuse_internal_getattr to use the
* cached attributes. Better yet, replace fvdat->filesize with
* attrs->va_size
*/
err = VOP_GETATTR(vp, &va, cred);
SDT_PROBE2(fusefs, , node, trace, 1, "refreshed file size");
return err;