Fix exp2*(x) on signaling NaNs by returning x+x as usual.
This has the side effect of confusing gcc-4.2.1's optimizer into more often doing the right thing. When it does the wrong thing here, it seems to be mainly making too many copies of x with dependency chains. This effect is tiny on amd64, but in some cases on i386 it is enormous. E.g., on i386 (A64) with -O1, the current version of exp2() should take about 50 cycles, but took 83 cycles before this change and 66 cycles after this change. exp2f() with -O1 only speeded up from 51 to 47 cycles. (exp2f() should take about 40 cycles, on an Athlon in either i386 or amd64 mode, and now takes 42 on amd64). exp2l() with -O1 slowed down from 155 cycles to 123 for some args; this is unimportant since the i386 exp2l() is a fake; the wrong thing for it seems to involve branch misprediction.
This commit is contained in:
parent
cafbfde84b
commit
517ddcfb70
@ -371,7 +371,7 @@ exp2l(long double x)
|
||||
if (u.xbits.manh != 0
|
||||
|| u.xbits.manl != 0
|
||||
|| (hx & 0x8000) == 0)
|
||||
return (x); /* x is NaN or +Inf */
|
||||
return (x + x); /* x is NaN or +Inf */
|
||||
else
|
||||
return (0.0); /* x is -Inf */
|
||||
}
|
||||
|
@ -226,7 +226,7 @@ exp2l(long double x)
|
||||
if (ix >= BIAS + 14) { /* |x| >= 16384 or x is NaN */
|
||||
if (ix == BIAS + LDBL_MAX_EXP) {
|
||||
if (u.xbits.man != 1ULL << 63 || (hx & 0x8000) == 0)
|
||||
return (x); /* x is NaN or +Inf */
|
||||
return (x + x); /* x is +Inf or NaN */
|
||||
else
|
||||
return (0.0); /* x is -Inf */
|
||||
}
|
||||
|
@ -351,7 +351,7 @@ exp2(double x)
|
||||
if(ix >= 0x7ff00000) {
|
||||
GET_LOW_WORD(lx,x);
|
||||
if(((ix & 0xfffff) | lx) != 0 || (hx & 0x80000000) == 0)
|
||||
return (x); /* x is NaN or +Inf */
|
||||
return (x + x); /* x is NaN or +Inf */
|
||||
else
|
||||
return (0.0); /* x is -Inf */
|
||||
}
|
||||
|
@ -104,7 +104,7 @@ exp2f(float x)
|
||||
if(ix >= 0x43000000) { /* |x| >= 128 */
|
||||
if(ix >= 0x7f800000) {
|
||||
if ((ix & 0x7fffff) != 0 || (hx & 0x80000000) == 0)
|
||||
return (x); /* x is NaN or +Inf */
|
||||
return (x + x); /* x is NaN or +Inf */
|
||||
else
|
||||
return (0.0); /* x is -Inf */
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user