d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert the rev. 1.4, it causes breakage on most arches except i386.

Browse Source 
Remove the const qualifier from ap argument for __v2printf, that induced
that breakage, and seems to be the real reason for bad code. ap is modified
inside the __v2printf body by va_arg macro.

Pointy hat to:	kib
Approved by:	pjd (mentor)
This commit is contained in:
Konstantin Belousov 2006-10-23 07:25:25 +00:00
parent 66bdd5d619
commit 525cd732f9
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/libc/stdio/xprintf.c
View File

@ -261,7 +261,7 @@ static struct {
static int
__v2printf(FILE *fp, const char *fmt0, unsigned pct, const va_list ap1)
__v2printf(FILE *fp, const char *fmt0, unsigned pct, va_list ap)
{
struct printf_info *pi, *pil;
const char *fmt;
@ -274,9 +274,7 @@ __v2printf(FILE *fp, const char *fmt0, unsigned pct, const va_list ap1)
int ret = 0;
int n;
struct __printf_io io;
va_list ap;
va_copy(ap, ap1);
__printf_init(&io);
io.fp = fp;
@ -563,7 +561,6 @@ __v2printf(FILE *fp, const char *fmt0, unsigned pct, const va_list ap1)
errx(1, "render[%c] = NULL", *fmt);
}
__printf_flush(&io);
va_end(ap);
return (ret);
}