d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Lock Giant in svr4_add_socket() so that the various svr4_*stat() calls

Browse Source 
can be marked MP safe as this is the only part of them that is not
already MP safe.

Approved by:	re (scottl)
This commit is contained in:
John Baldwin 2005-07-07 19:27:29 +00:00
parent 03badf38ab
commit 55522478e6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/compat/svr4/svr4_socket.c
View File

@ -47,6 +47,8 @@ __FBSDID("$FreeBSD$");
#include <sys/systm.h>
#include <sys/queue.h>
#include <sys/file.h>
#include <sys/lock.h>
#include <sys/mutex.h>
#include <sys/socket.h>
#include <sys/socketvar.h>
#include <sys/sysproto.h>
@ -114,6 +116,8 @@ svr4_add_socket(td, path, st)
struct svr4_sockcache_entry *e;
int len, error;
mtx_lock(&Giant);
/*
* Wait for the TAILQ to be initialized. Only the very first CPU
* will succeed on the atomic_cmpset(). The other CPU's will spin
@ -135,6 +139,7 @@ svr4_add_socket(td, path, st)
if ((error = copyinstr(path, e->sock.sun_path,
sizeof(e->sock.sun_path), &len)) != 0) {
mtx_unlock(&Giant);
DPRINTF(("svr4_add_socket: copyinstr failed %d\n", error));
free(e, M_TEMP);
return error;
@ -144,6 +149,7 @@ svr4_add_socket(td, path, st)
e->sock.sun_len = len;
TAILQ_INSERT_HEAD(&svr4_head, e, entries);
mtx_unlock(&Giant);
DPRINTF(("svr4_add_socket: %s [%p,%d,%d]\n", e->sock.sun_path,
td->td_proc, e->dev, e->ino));
return 0;