Address a potential memory leak found a the clang static code analyzer
running on the userland stack. MFC after: 3 days
This commit is contained in:
parent
a5c6318fc3
commit
56d2f7d8e5
@ -542,7 +542,7 @@ sctp_insert_sharedkey(struct sctp_keyhead *shared_keys,
|
||||
}
|
||||
}
|
||||
/* shouldn't reach here */
|
||||
return (0);
|
||||
return (EINVAL);
|
||||
}
|
||||
|
||||
void
|
||||
@ -622,8 +622,11 @@ sctp_copy_skeylist(const struct sctp_keyhead *src, struct sctp_keyhead *dest)
|
||||
LIST_FOREACH(skey, src, next) {
|
||||
new_skey = sctp_copy_sharedkey(skey);
|
||||
if (new_skey != NULL) {
|
||||
(void)sctp_insert_sharedkey(dest, new_skey);
|
||||
count++;
|
||||
if (sctp_insert_sharedkey(dest, new_skey)) {
|
||||
sctp_free_sharedkey(new_skey);
|
||||
} else {
|
||||
count++;
|
||||
}
|
||||
}
|
||||
}
|
||||
return (count);
|
||||
|
Loading…
x
Reference in New Issue
Block a user