d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix uninitialized warning, and work around a bug in gcc over clobbering

Browse Source 
Summary:
r329077 caused gcc to emit uninitialized use warnings.  Attempting to
fix those warnings yielded the following warnings:

usr.bin/tftp/main.c: In function 'main':
usr.bin/tftp/main.c:181: warning: variable 'el' might be clobbered by
'longjmp' or 'vfork'
usr.bin/tftp/main.c:182: warning: variable 'hist' might be clobbered by
'longjmp' or 'vfork'

This is a known bug in gcc, found at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24239

Work around that by simply marking hist and el as static.

Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D14302
This commit is contained in:
jhibbits 2018-02-10 17:17:15 +00:00
parent 7f5b337a61
commit 5a559c7cff
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
usr.bin/tftp/main.c
View File

@ -178,8 +178,8 @@ int
main(int argc, char *argv[])
{
HistEvent he;
EditLine *el;
History *hist;
static EditLine *el;
static History *hist;
bool interactive;
acting_as_client = 1;