d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a loop instead of a goto in sysctl_kern_proc_kstack().

Browse Source 
MFC after:	3 days
This commit is contained in:
markj 2016-04-17 23:22:32 +00:00
parent 806ab8645b
commit 5af0054863
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/kern/kern_proc.c
View File

@ -2534,10 +2534,8 @@ sysctl_kern_proc_kstack(SYSCTL_HANDLER_ARGS)
st = stack_create(); st = stack_create();
lwpidarray = NULL; lwpidarray = NULL;
numthreads = 0;
PROC_LOCK(p); PROC_LOCK(p);
repeat: do {
if (numthreads < p->p_numthreads) {
if (lwpidarray != NULL) { if (lwpidarray != NULL) {
free(lwpidarray, M_TEMP); free(lwpidarray, M_TEMP);
lwpidarray = NULL; lwpidarray = NULL;
@ -2547,9 +2545,7 @@ repeat:
lwpidarray = malloc(sizeof(*lwpidarray) * numthreads, M_TEMP, lwpidarray = malloc(sizeof(*lwpidarray) * numthreads, M_TEMP,
M_WAITOK | M_ZERO); M_WAITOK | M_ZERO);
PROC_LOCK(p); PROC_LOCK(p);
goto repeat; } while (numthreads < p->p_numthreads);
}
i = 0;
/* /*
* XXXRW: During the below loop, execve(2) and countless other sorts * XXXRW: During the below loop, execve(2) and countless other sorts
@ -2560,6 +2556,7 @@ repeat:
* have changed, in which case the right to extract debug info might * have changed, in which case the right to extract debug info might
* no longer be assured. * no longer be assured.
*/ */
i = 0;
FOREACH_THREAD_IN_PROC(p, td) { FOREACH_THREAD_IN_PROC(p, td) {
KASSERT(i < numthreads, KASSERT(i < numthreads,
("sysctl_kern_proc_kstack: numthreads")); ("sysctl_kern_proc_kstack: numthreads"));