d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use snprintf(3) instead of sprintf(3)

Browse Source 
Remove useless "else"
This commit is contained in:
Baptiste Daroussin 2015-05-09 22:43:44 +00:00
parent 8592cfc58e
commit 5d8ece9a4b
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
usr.sbin/pw/pw_user.c
View File

@ -1018,17 +1018,16 @@ static char *
pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user) pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user)
{ {
struct carg *arg = getarg(args, 'd'); struct carg *arg = getarg(args, 'd');
static char home[128];
if (arg) if (arg)
return arg->val; return (arg->val);
else {
static char home[128];
if (cnf->home == NULL || *cnf->home == '\0') if (cnf->home == NULL || *cnf->home == '\0')
errx(EX_CONFIG, "no base home directory set"); errx(EX_CONFIG, "no base home directory set");
sprintf(home, "%s/%s", cnf->home, user); snprintf(home, sizeof(home), "%s/%s", cnf->home, user);
return home;
} return (home);
} }
static char * static char *