From 5eee50ca3619c4fd92c6f420733cd71a1d39c3ed Mon Sep 17 00:00:00 2001 From: rwatson Date: Sat, 9 Sep 2006 16:09:01 +0000 Subject: [PATCH] Remove slightly oddly placed suser() call from the KTR/ALQ setup sysctl: it was present only in the enable path, not the disable path, which one presumes would be equally of interest. Either way, it was not needed, as the sysctl framework already calls suser() if the operation is a write operation, which configuration requests are. Sponsored by: nCircle Network Security, Inc. --- sys/kern/kern_ktr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/kern/kern_ktr.c b/sys/kern/kern_ktr.c index f12f97153fd9..721cc528e3b9 100644 --- a/sys/kern/kern_ktr.c +++ b/sys/kern/kern_ktr.c @@ -163,9 +163,6 @@ sysctl_debug_ktr_alq_enable(SYSCTL_HANDLER_ARGS) if (enable) { if (ktr_alq_enabled) return (0); - error = suser(curthread); - if (error) - return (error); error = alq_open(&ktr_alq, (const char *)ktr_alq_file, req->td->td_ucred, ALQ_DEFAULT_CMODE, sizeof(struct ktr_entry), ktr_alq_depth);