d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Assert that the bufobj matches in flushbuflists. I still haven't gotten

Browse Source 
to root cause on exactly how this happens.
 - If the assert is disabled, we presently try to handle this case, but the
   BUF_UNLOCK was missing.  Thus, if this condition ever hit we would leak
   a buf lock.

Many thanks to Peter Holm for all his help in finding this bug.  He really
put more effort into it than I did.
This commit is contained in:
jeff 2005-04-06 06:49:46 +00:00
parent 3e09e80261
commit 60d07eec30
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/kern/vfs_subr.c
View File

@ -1040,7 +1040,10 @@ flushbuflist(bufv, flags, bo, slpflag, slptimeo)
BO_LOCK(bo); BO_LOCK(bo);
return (error != ENOLCK ? error : EAGAIN); return (error != ENOLCK ? error : EAGAIN);
} }
KASSERT(bp->b_bufobj == bo,
("wrong b_bufobj %p should be %p", bp->b_bufobj, bo));
if (bp->b_bufobj != bo) { /* XXX: necessary ? */ if (bp->b_bufobj != bo) { /* XXX: necessary ? */
BUF_UNLOCK(bp);
BO_LOCK(bo); BO_LOCK(bo);
return (EAGAIN); return (EAGAIN);
} }