d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use vaccess() instead of rolling our own access checks. This fixes a bug

Browse Source 
where requests to open a file in append mode were always denied, and
will also be useful when capabilities and auditing are implemented.
This commit is contained in:
tjr 2003-02-03 09:04:34 +00:00
parent d15a58ad27
commit 60ef21c151
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/fs/smbfs/smbfs_vnops.c
View File

@ -139,10 +139,9 @@ smbfs_access(ap)
} */ *ap;
{
struct vnode *vp = ap->a_vp;
struct ucred *cred = ap->a_cred;
u_int mode = ap->a_mode;
mode_t mode = ap->a_mode;
mode_t mpmode;
struct smbmount *smp = VTOSMBFS(vp);
int error = 0;
SMBVDEBUG("\n");
if ((mode & VWRITE) && (vp->v_mount->mnt_flag & MNT_RDONLY)) {
@ -153,15 +152,10 @@ smbfs_access(ap)
break;
}
}
if (cred->cr_uid == 0)
return 0;
if (cred->cr_uid != smp->sm_args.uid) {
mode >>= 3;
if (!groupmember(smp->sm_args.gid, cred))
mode >>= 3;
}
error = (((vp->v_type == VREG) ? smp->sm_args.file_mode : smp->sm_args.dir_mode) & mode) == mode ? 0 : EACCES;
return error;
mpmode = vp->v_type == VREG ? smp->sm_args.file_mode :
smp->sm_args.dir_mode;
return (vaccess(vp->v_type, mpmode, smp->sm_args.uid,
smp->sm_args.gid, ap->a_mode, ap->a_cred, NULL));
}
/* ARGSUSED */