d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

o Fix semantics of comparison function for qsort(3). According to qsort(3)

Browse Source 
manpage:

     The comparison function must return an integer less than, equal to, or
     greater than zero if the first argument is considered to be respectively
     less than, equal to, or greater than the second.

  Therefore, simply returning "arg1 > arg2" is incorrect. Actually it works
  but for the number of items to be sorted less than 7 due to special case
  handling in qsort(3);

o add missing '\n' to one of usage() calls.

Approved by:	phk
This commit is contained in:
Maxim Sobolev 2004-06-25 13:04:49 +00:00
parent 2758535974
commit 6122c0cd5e
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sbin/gbde/gbde.c
View File

@ -480,7 +480,11 @@ sorthelp(const void *a, const void *b)
oa = a;
ob = b;
return (*oa > *ob);
if (*oa > *ob)
return 1;
if (*oa < *ob)
return -1;
return 0;
}
static void
@ -721,7 +725,7 @@ main(int argc, char **argv)
if ((i = modfind("g_bde")) < 0) {
/* need to load the gbde module */
if (kldload(GBDEMOD) < 0 || modfind("g_bde") < 0) {
usage(GBDEMOD ": Kernel module not available");
usage(GBDEMOD ": Kernel module not available\n");
}
}
doopen = 0;