d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cxgbe(4): Make it clear that VI_INIT_DONE implies vi->ntxq > 0, and so

Browse Source 
rc will never be returned uninitialized.

Reported by:	Coverity (CID 1394884).  This is a false positive though.
Sponsored by:	Chelsio Communications
This commit is contained in:
np 2018-08-21 21:42:17 +00:00
parent db7bc7e6df
commit 62b1de7f2f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sys/dev/cxgbe/t4_sched.c
View File

@ -394,6 +394,7 @@ t4_set_sched_queue(struct adapter *sc, struct t4_sched_queue *p)
/* Checking VI_INIT_DONE outside a synch-op is a harmless race here. */
if (!(vi->flags & VI_INIT_DONE))
return (EAGAIN);
MPASS(vi->ntxq > 0);
if (!in_range(p->queue, 0, vi->ntxq - 1) ||
!in_range(p->cl, 0, sc->chip_params->nsched_cls - 1))